Fix quantifiers with nested statement-expressions#8616
Merged
tautschnig merged 1 commit intodevelopfrom Apr 4, 2025
Merged
Conversation
qinheping
requested review from
kroening,
peterschrammel,
remi-delmas-3000 and
tautschnig
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8616 +/- ##
===========================================
- Coverage 80.38% 80.37% -0.01%
===========================================
Files 1686 1686
Lines 206770 206782 +12
Branches 85 85
===========================================
- Hits 166207 166204 -3
- Misses 40563 40578 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tautschnig
reviewed
Apr 3, 2025
qinheping
force-pushed
the
quantifiers_with_statement_expresssion
branch
from
4ddfdbf to
25e6c7b
Compare
tautschnig
force-pushed
the
quantifiers_with_statement_expresssion
branch
from
25e6c7b to
add2b0a
Compare
- Added support for `ID_address_of` and 'ID_typecast` expressions to `find_base_symbol`. - Corrected the multi-path handling in `convert_statement_expression`---a path not reaching the terminal expression should be ignored.
tautschnig
force-pushed
the
quantifiers_with_statement_expresssion
branch
from
add2b0a to
8b319da
Compare
tautschnig
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ID_address_ofand 'ID_typecastexpressions tofind_base_symbol`.convert_statement_expression---a path not reaching the terminal expression should result infalse.